-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Moonraker user authorization #370
base: develop
Are you sure you want to change the base?
Conversation
Having no authorization at all in Mainsail is quite a bummer for using Mainsail in a company environment or with a hyperactive teenager in house. Without any authorization, one will easily manipulate other's printer by a mistake. Would you please consider implementing some kind of authorization? Thanks for great work. |
Any news on when this feature will be added to Mainsail ? |
Looking forward to this being implemented so I can use mainsail again with moonraker auth. |
I tested your implementation and really like it. |
bummer this seems not be given any attention |
Yeah as the description says the refresh token handling is missing. I guess you would need to store it in local storage. I stopped working on this PR because at the time Mete was not willing to merge it because he was working on his own implementation. |
@goesta that must have been a communication problem then. I only uploaded my branch so that you could possibly take over parts of it. that's why I didn't work on it any further. |
Would love to see this implemented. Been using the feature for a few weeks now, I have two issues:
This is what my browser shows:
|
hello, i am new to all this authorization stuff and i need help. i have a voron that operates using mainsail, i would like to password protect the mainsail webserver from students trying to access the printer. i am trying to implement the PR, i just added the authorization code block into the mookraker.conf file and am stuck with what to do next. any help would be greatly appreciated. |
I would suggest you use Fluidd instead since it supports authentication natively. Alternatively you can use basic Auth in nginx. |
keep in mind that moonraker authentication (which uses fluidd) is NOT intended for the public internet! this is at most an intranet protection! |
I initially tried to use nginx on ubuntu using their example on their website here: https://docs.nginx.com/nginx/admin-guide/security-controls/configuring-http-basic-authentication/. To sum up, the example code is shown below. However, I kept running into errors and I couldn't find the api key on mainsail. I am pretty sure there is something I am not understanding though.
}` |
This PR adds Support for Moonraker user authorization.
https://moonraker.readthedocs.io/en/latest/web_api/#authorization
https://moonraker.readthedocs.io/en/latest/configuration/#authorization
How to use it:
force_logins: True
to the[authorization]
section in your moonraker.cfgWhats missing:
The refresh token handling. The remember me checkbox is just a dummy for now.
closes(#267)