Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo issues with save zoffset for probes #1821

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: fix typo issues with save zoffset for probes #1821

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80ce91
fix: fix typo issues with save zoffset for probes
meteyou Mar 17, 2024
5b6d9bf
refactor: simplify search function
meteyou Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/mixins/zoffset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,15 @@ export default class ZoffsetMixin extends Vue {
get endstop_pin() {
const stepperConfig = this.settings[this.stepper_name] ?? {}

return stepperConfig?.endstop_pin
return stepperConfig?.endstop_pin.trim()
}

get zOffset(): number {
return this.$store.state.printer?.gcode_move?.homing_origin[2].toFixed(3)
}
get isEndstopProbe() {
return this.endstop_pin.search('probe:z_virtual_endstop') !== -1
// this is to check all kinds of writings
return this.endstop_pin.startsWith('probe:') && this.endstop_pin.endsWith('z_virtual_endstop')
}

get existZOffsetApplyProbe() {
Expand Down
Loading