Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timelapse): fix issue with changing timelapse settings #1745

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jan 12, 2024

Description

This PR fixes the issue with hidden timelapse navi point (after adding a wrong value in the settings) and add input rules to the timelapse settings.

Related Tickets & Documents

fixes #1740

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0 and rackrick January 12, 2024 21:02
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 1 0

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 1 0

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

Co-authored-by: rackrick <[email protected]>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

# Conflicts:
#	src/plugins/webSocketClient.ts
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

Signed-off-by: Stefan Dej <[email protected]>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

@meteyou meteyou merged commit 4f43c89 into mainsail-crew:develop Jan 29, 2024
10 checks passed
@meteyou meteyou deleted the fix/timelapse-settings branch January 29, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timelapse disappears when trying to change settings.
2 participants