feat: add facility to Scan Metadata from G-code Files #1316
Conversation
Added Scan Metadata option in the gcode file right click menu to call the Metascan Moonraker endpoint to process files that are not auto processed because they are on a network mount or other drive that doesnt support inotify. added a small delay to allow for thumbnail processing as it sometimes took two scans to get the meta and thumbnail.
added supporting phrases for the scan metadata option in gcode files.
|
Language file analysis report:
|
|
Thx for your PR. I didn't know that Moonraker had this function by now. Why do you use the HTTP request, not the WebSocket, to update the metadata? |
|
No specific reason other than that is what i had been testing with using postman so i knew the behaviour. The api endpoint has some slightly odd behaviours. Such as if the file doesnt exist then it automatically scans the entire document tree. |
|
i would prefer to use websocket and send the result to the action files/getMetadata to store the new metadata in the state |
meteyou
changed the title
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
|
@siparker pls enable pushing to this branch/pr. I refactored this to switch to websocket requests, but i'm not allowed to push it in your branch. |
Hi, After a few mins of searching apparently there is a bug to allow edits for maintainers in a push request from an Org. https://github.com/orgs/community/discussions/5634 I have added you as a collaborator on the develop branch, hopefully that allows it? |
|
Language file analysis report:
|
|
Ok. but there was also an issue on my side. I also had to use a own taken for this branch. This could also be my issue. But now it worked. I pushed my changes. Please, double-check it! |
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
When viewing a mounted network drive gcode files that are added to the network share and not uploaded via Mainsail do not contain any meta data or thumbnails.
This was originally raised as an issue within Moonraker Arksine/moonraker#614 and determined to be an issue with some mount options, for example cifs, did not properly run inotify events which moonraker relies on.
There was already a moonraker API endpoint /server/files/metascan that can scan existing files so we just added the option to right click and scan meta data via Mainsail instead of trying to cover every mount type and inotify compatibility issues.