Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some macros do not report their parameters #436

Closed
RomRider opened this issue Nov 29, 2021 · 1 comment · Fixed by #437
Closed

Some macros do not report their parameters #436

RomRider opened this issue Nov 29, 2021 · 1 comment · Fixed by #437
Labels
⚡ Type: Bug Something isn't working

Comments

@RomRider
Copy link
Contributor

Describe the bug:
Some macros do not report requiring parameters in the interface
Eg:

[gcode_macro SET_BED_SOAK_TIME]
gcode:
  SAVE_VARIABLE VARIABLE=bed_soak_time VALUE={params.SECONDS|default(120)}

While some of them do:

[gcode_macro SET_INFILL_SQV]
gcode:
    {% set svv = printer.save_variables.variables %}
    {% set val = params.SQV|default(svv.infill_sqv|default(printer.configfile.settings.printer.square_corner_velocity, true), true) | int %}
    SAVE_VARIABLE VARIABLE=infill_sqv VALUE={val}

Expected behavior:
The macro with parameters should report their parameters in the interface.

Screenshots:
image

Logfiles:
Please upload your Logfiles here or upload them to pastebin.com and paste your log links here.

  • klippy.log
  • moonraker.log
@RomRider RomRider added the ⚡ Type: Bug Something isn't working label Nov 29, 2021
RomRider added a commit to RomRider/mainsail that referenced this issue Nov 29, 2021
@freasy
Copy link
Contributor

freasy commented Nov 29, 2021

See my comment on: #437

meteyou pushed a commit that referenced this issue Nov 29, 2021
* Fix macro param regexp

Fix #436

* Simplify regexp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants