Switch to Vitest because it supports ESM #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
switch-to-vitest
branch
from
db156b2 to
a8d51bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2065
I was reminded that jest does not have adequate TS / ESM support (it still thinks everything is cjs -- and just technically can be set up to work with native ESM, but it's a huuuuge pain, and no one has time for that).
So here is jest replaced by vitest.
I had the option of keeping the "globals" support, but it's better practice to import the things used rather than rely on globals (makes types and eslint easier when imported)
Both before and after this change are 39 test files with 329 tests.