Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today, qunit-dom's default path points to the wrong file.
in a real ESM environment,
import * as anything from 'qunit-dom'
points at the ember addon index.js instead of anything useful.I've been working towards getting v2 addon testing to be much less a pain in the butt, so I'm going full ESM with Vite (which I know will require a bunch of work when I get to dealing with the emberisms), but qnuit-dom should probably be compatible with ESM environments anyway. Here is the patch I made here: https://github.com/NullVoxPopuli/ember-resources/pull/585/files#diff-654ac9908e210063f32fb8d67f4742e747b8b19fd85f087b265fe81147eda554
Some proof: