Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESM #1674

Closed
wants to merge 1 commit into from
Closed

Support ESM #1674

wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link
Contributor

today, qunit-dom's default path points to the wrong file.

in a real ESM environment, import * as anything from 'qunit-dom' points at the ember addon index.js instead of anything useful.

I've been working towards getting v2 addon testing to be much less a pain in the butt, so I'm going full ESM with Vite (which I know will require a bunch of work when I get to dealing with the emberisms), but qnuit-dom should probably be compatible with ESM environments anyway. Here is the patch I made here: https://github.com/NullVoxPopuli/ember-resources/pull/585/files#diff-654ac9908e210063f32fb8d67f4742e747b8b19fd85f087b265fe81147eda554
Some proof:
image

@Turbo87
Copy link
Collaborator

Turbo87 commented Nov 23, 2022

given emberjs/data#8296 (comment), I'm not sure about merging this 🤔

@SergeAstapov
Copy link
Contributor

@Turbo87 do you think it worth converting this to v2 addon to achieve wheat is being asked here?

@Turbo87
Copy link
Collaborator

Turbo87 commented Nov 24, 2022

depends on what that means 😅

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Nov 24, 2022

My goal is simple: use ember's tools without ember-cli. By using only script type=module.

Converting to a v2 addon is mostly mechanical file moves

  • after the tests are split out
  • npm packages has compiled assets only
    Stuff like that.

It's an ecosystem requirement to convert all addons to the v2 requirement so that we can one day use modern tooling.

I'm more than happy to do full v2 conversation of this addon, it would have to be a breaking change tho

@NullVoxPopuli
Copy link
Contributor Author

Gonna close this in favor of converting the library to a v2 addon.

Given how broad the support is for qunit-dom today, some breaking changes will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants