Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasAria() docs and add hasNoAria() and lacksAria() aliases #1481

Merged
merged 4 commits into from
Mar 10, 2022

Conversation

jamescdavis
Copy link
Contributor

@jamescdavis jamescdavis commented Mar 2, 2022

This:

  • updates the link in hasAria()'s doc block from hasNoAria() to doesNotHaveAria()
  • adds hasNoAria() and lacksAria() as aliases for doesNotHaveAria() to be consistent with hasNoAttribute() and lacksAttribute() aliases for doesNotHaveAttribute() (and other doesNotHave assertions)
  • updates the example in doesNotHaveAttribute() to use doesNotHaveAttribute() instead of its alias hasNoAttribute()

Note: I can't get pnpm run docs to succeed so this PR doesn't update API.md

@Turbo87
Copy link
Collaborator

Turbo87 commented Mar 2, 2022

what do you think about adding hasNoAria() (similar to hasNoAttribute()) instead?

@jamescdavis
Copy link
Contributor Author

I think it makes sense to add hasNoAria() and lacksAria() as aliases to be consistent with the hasNoAttribute() and lacksAttribute() aliases for doesNotHaveAttribute().

@jamescdavis jamescdavis force-pushed the fix_doesNotHaveAria_link branch from 49a69c9 to 98841f0 Compare March 3, 2022 18:22
@jamescdavis jamescdavis changed the title docs: s/hasNoAria/doesNotHaveAria/ s/hasNoAria/doesNotHaveAria/ in hasAria in docs and add hasNoAria/lacksAria aliases Mar 3, 2022
@jamescdavis
Copy link
Contributor Author

@Turbo87 I've expanded this PR to add those aliases.

Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@Turbo87 Turbo87 changed the title s/hasNoAria/doesNotHaveAria/ in hasAria in docs and add hasNoAria/lacksAria aliases Fix hasAria() docs and add hasNoAria() and lacksAria() aliases Mar 10, 2022
@Turbo87 Turbo87 merged commit bcb67e0 into mainmatter:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants