Skip to content

Commit

Permalink
Merge pull request #351 from Turbo87/tests
Browse files Browse the repository at this point in the history
Use new `ember-qunit` testing APIs
  • Loading branch information
Turbo87 authored May 3, 2019
2 parents 6cc97a7 + cc87cce commit 637195f
Show file tree
Hide file tree
Showing 5 changed files with 83 additions and 147 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@
"ember-cli-htmlbars": "^3.0.0",
"ember-cli-htmlbars-inline-precompile": "^2.0.0",
"ember-cli-inject-live-reload": "^2.0.1",
"ember-cli-qunit": "^4.0.0",
"ember-load-initializers": "^2.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-qunit": "^4.4.1",
"ember-resolver": "^5.1.3",
"ember-source": "~3.9.1",
"eslint": "^5.16.0",
Expand Down
24 changes: 11 additions & 13 deletions tests/acceptance/qunit-dom-test.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
/* eslint-env embertest */
import { module, test } from 'qunit';
import { setupApplicationTest } from 'ember-qunit';
import { visit } from '@ember/test-helpers';

import { test } from 'qunit';
import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';
module('Acceptance | qunit-dom', function(hooks) {
setupApplicationTest(hooks);

moduleForAcceptance('Acceptance | qunit-dom');
test('qunit-dom assertions are available', async function(assert) {
assert.ok(assert.dom, 'assert.dom is available');
assert.ok(assert.dom('.foo').includesText, 'assert.dom(...).includesText is available');

test('qunit-dom assertions are available', function(assert) {
assert.expect(15);
assert.dom('#qunit').doesNotExist('rootElement is set to #ember-testing-container');

assert.ok(assert.dom, 'assert.dom is available');
assert.ok(assert.dom('.foo').includesText, 'assert.dom(...).includesText is available');
assert.dom().hasAttribute('id', 'ember-testing');

assert.dom('#qunit').doesNotExist('rootElement is set to #ember-testing-container');
await visit('/');

assert.dom().hasAttribute('id', 'ember-testing');

visit('/');
andThen(() => {
assert.dom('#title').exists();
assert.dom('#subtitle').doesNotExist();
assert.dom('#title').hasText('Welcome to Ember');
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ module.exports = function(environment) {
ENV.APP.LOG_VIEW_LOOKUPS = false;

ENV.APP.rootElement = '#ember-testing';
ENV.APP.autoboot = false;
}

if (environment === 'production') {
Expand Down
10 changes: 6 additions & 4 deletions tests/test-helper.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import resolver from './helpers/resolver';
import { setResolver } from '@ember/test-helpers';
import { start } from 'ember-cli-qunit';
import Application from '../app';
import config from '../config/environment';
import { setApplication } from '@ember/test-helpers';
import { start } from 'ember-qunit';

setApplication(Application.create(config.APP));

setResolver(resolver);
start();
Loading

0 comments on commit 637195f

Please sign in to comment.