Fix caching warnings when running under Embroider #742
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, you would receive the following warnings during an Embroider build:
The reason for this warning is that Embroider is attempting to read the caching information (baseDir and cacheKey) from the plugin itself (not the wrapper we register). Some recent changes in Embroider have improved things a bit (reducing the number of cases where this warning will occur), but fixing all scenarios is quite difficult.
This PR works around the issue by placing the caching information on both the registries wrapper object and the plugin itself (ensuring that there is still a single source of truth).
This fixes the warning you get when running in Embroider builds.