Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dummy/components: Explicitly set attributeBindings to [] to test freezing #63

Merged
merged 2 commits into from
Jan 25, 2017
Merged

dummy/components: Explicitly set attributeBindings to [] to test freezing #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea47009
dummy/components: Explicitly set attributeBindings to [] to test free…
Turbo87 Jan 25, 2017
cf32689
dummy/components: Add comment explaining the reasons for this override
Turbo87 Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/dummy/app/components/data-test-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import Ember from 'ember';

export default Ember.Component.extend({
// we're explicitly setting attributeBindings here to test that
// we are correctly slice()ing the frozen array if it exists already
attributeBindings: [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting why you're doing this for your future self :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgentry good point, thanks. I've added a code comment explaining why we override this property.

});