Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace initializer with IIFE in the vendor tree #52

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Replace initializer with IIFE in the vendor tree #52

merged 1 commit into from
Jan 17, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jan 17, 2017 •
edited
Loading

This PR remove the need for having an initializer the reopens the component, and also the need for doing the reopening in the test-helpers file

Resolves #49

/cc @bgentry

@Turbo87 Turbo87 requested review from marcoow and pangratz January 17, 2017 10:46
pangratz
pangratz approved these changes Jan 17, 2017
View reviewed changes
Copy link
Contributor

@pangratz pangratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Turbo87 Turbo87 merged commit 62070d2 into mainmatter:master Jan 17, 2017
@Turbo87 Turbo87 deleted the kill-initializer branch January 17, 2017 11:35
@bgentry
Copy link
Contributor

bgentry commented Jan 17, 2017 •
edited
Loading

That's a much cleaner and more clever way to accomplish the same result. Nice! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pangratz pangratz pangratz approved these changes

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Turbo87 @bgentry @marcoow @pangratz