add blueprint + test helper for integration tests #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borrowing from an approach used by ember-cli-flash, we add a helper to duplicate the behavior of the initializer when we're running an integration test (where initializers are not loaded). Add a blueprint that auto-installs this helper and loads it in tests/test-helepr.js.
|
Thanks, looks great! We'll test the blueprint in some of our projects and maybe add a test for it next week! |
|
@marcoow awesome! I also realized after submitting this that maybe I could just import the initializer directly and call that here? That would avoid duplicating the code around Is there a non-manual way to test blueprints? I couldn't find any projects that were doing such a thing. |
|
@bgentry it's possible using |
|
@bgentry thanks a lot for making us aware of this issue and providing a solution at the same time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowing from an approach used by ember-cli-flash, we add a helper to duplicate the behavior of the initializer when we're running an integration test (where initializers are not loaded). Also, add a blueprint that auto-installs this helper and loads it in
tests/test-helepr.js.I haven't actually run the blueprint itself, but I did manually make the changes it would make on my own app and that fixed the issue I was having.
Hopefully this does the trick!
Fixes #49.