Simplify testSelector() import #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
requested changes
Jan 11, 2017
| id: 'ember-test-selectors.test-selector-import', | ||
| until: '0.1.0', | ||
| url: 'https://github.com/simplabs/ember-test-selectors#test-helpers', | ||
| }); |
There was a problem hiding this comment.
As we're pre 1.0.0 we can (and I think should for simplicity's sake) just remove this.
There was a problem hiding this comment.
so far we haven't introduced any breaking changes and removing this would be a breaking change without any deprecation first. I'm not a fan of breaking API without deprecations if deprecations are possible in a simple way.
There was a problem hiding this comment.
OK, cool - I just want to make sure we get rid of this until 1.0.0.
marcoow
approved these changes
Jan 11, 2017
pangratz
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
The old import still works, but displays a deprecation warning. Due to the fact that our
addonandappfolders are only packaged in testing mode we don't have to worry about including testing code in the production build.