Introduce "strip" and deprecate "environments" option #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to register it for the addon *and* the parent app
Actually, we don't replace it, but instead we deprecate the old option and introduce the new option on the side
marcoow
reviewed
Jan 9, 2017
| var StripTestSelectorsTransform = require('./strip-test-selectors'); | ||
| if (addonOptions.environments) { | ||
| ui.writeDeprecateLine('The "environments" option in "ember-test-selectors" has been replaced ' + | ||
| 'with a "strip" option. Use e.g. "strip: EmberApp.env() === \'production\'" instead to ' + |
There was a problem hiding this comment.
my gut feeling says "with a "strip" option" sounds better, but I'm happy with either. maybe we should ask a native english speaker. 🤷♂️
There was a problem hiding this comment.
we should ask a native english speaker
👍 /cc @oliverbarnes, @sapeien
There was a problem hiding this comment.
the would be more correct in my opinion, because it matches the the from the beginning of the sentence.
There was a problem hiding this comment.
Concur about the over a.
There was a problem hiding this comment.
Updated. Thanks everyone!
pangratz
approved these changes
Jan 9, 2017
marcoow
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41