Revert "Use setupPreprocessorRegistry() hook to register HTMLBars AST plugin"
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Apr 18, 2019
…ST plugin" This reverts commit 8d4ee86.
Turbo87
force-pushed
the
revert-preproreg
branch
from
ddb26ed to
4134746
Compare
rwjblue
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #338 to fix #345
It turns out that ember-cli/ember-cli#7059 does not quite work for us in addon builds as we still don't have access to the
EmberAppinstance in that case. We will look into fixing this in CLI itself, but in the meantime, reverting this should fix the immediate issue and enable us to take advantage of the Babel/HBS parallelization.I've tested this variant in a production app and a fresh
ember addonand it seems to do the right thing in both cases, for both dev and prod builds./cc @rwjblue