Handle components with empty tag name #323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension to existing PR #291 which handles addition of attribute
supportsDataTestProperties
I tried using the PR but it throws an exception
You cannot use
attributeBindingson a tag-less component
while running following code:as the attribute bindings can not be set on component with empty
tagName
This PR just adds an early exit in util
bind-data-test-attributes
in case of tag-less component and an acceptance test on top of existing PR #291Resolves #290, Closes #291