Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check value argument for absence, not falsiness. #24

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Check value argument for absence, not falsiness. #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test-support/helpers/ember-test-selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import Ember from 'ember';

const {
isNone
} = Ember;

export default function testSelector(key, value) {
let selector;
if (value) {
if (!isNone(value)) {
selector = `[data-test-${key}="${value}"]`;
} else {
selector = `[data-test-${key}]`;
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test-support/helpers-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ module('test-support helpers');

test('expands a selector name and attribute value corretly', function(assert) {
assert.equal(testSelector('selector', 'welcome-text'), '[data-test-selector="welcome-text"]');
assert.equal(testSelector('selector', 0), '[data-test-selector="0"]');
});

test('expands a selector name without attribute value corretly', function(assert) {
Expand Down