Deprecate testSelector() helper #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
commented
Jul 14, 2017
| find(testSelector('post-title')) // => find('[data-test-post-title]') | ||
| find(testSelector('resource-id', '2')) // => find('[data-test-resource-id="2"]') | ||
| find('[data-test-post-title]') | ||
| find('[data-test-resource-id="2"]') |
There was a problem hiding this comment.
This diff is actually the perfect explanation of why I think the helper was a bad idea in the first place ;)
Turbo87
requested changes
Jul 14, 2017
README.md
Outdated
| Once you've done that you can use the `testSelector()` function to create | ||
| a CSS/jQuery selector that looks up the right elements: | ||
| Once you've done that you can use an attribute selectors to look up the | ||
| elements: |
addon/index.js
Outdated
| const { isNone, deprecate } = Ember; | ||
|
|
||
| const message = `Using the "testSelector" helper function is deprecated as it obfuscates the selectors, making the tests harder to follow. | ||
| Please write the actual abbribute selectors you need instead, e.g. "[data-test-my-element]" instead of "testSelector('my-element')".`; |
There was a problem hiding this comment.
abbribute sounds like a funny little thing 😜
There was a problem hiding this comment.
Please use instead of Please write sounds better IMHO
marcoow
force-pushed
the
deprecate-test-helper
branch
from
17c3cb2 to
a9713c8
Compare
|
@Turbo87: fixed the surprisingly large amount of typos ;) |
Turbo87
approved these changes
Jul 14, 2017
Turbo87
changed the title
|
@ryanto the function is/was essentially just a one liner, so it should be reasonable to just import it in your codebase as a test helper module |
|
I wrote a codemod to transform code to the new style. Hope it's helpful :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
testSelectorhelper and propagates using the respective attribute selectors directly instead. Besides obfuscating what's going on, thetestSelectorhelper doesn't really do much.