Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ember-cli-babel@6 compatibility #102

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Fix ember-cli-babel@6 compatibility #102

merged 1 commit into from
Apr 24, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Apr 24, 2017

/cc @rwjblue

@Turbo87 Turbo87 added the bug label Apr 24, 2017
@Turbo87 Turbo87 requested a review from marcoow April 24, 2017 06:46
@marcoow
Copy link
Member

marcoow commented Apr 24, 2017

Should there be any test cases asserting this works with Babel 5 and 6?

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Apr 24, 2017

Unfortunately that is very hard to test. We are testing both of the Babel plugins themselves, but hadn't tested the glue code yet. I've verified this with #96 though.

@marcoow marcoow merged commit 9ceb7ea into mainmatter:master Apr 24, 2017
@Turbo87 Turbo87 deleted the fix-babel-compat branch April 24, 2017 07:18
rwjblue
rwjblue reviewed Apr 24, 2017
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this, it is a bit annoying for sure but required for support of older ember-cli versions. 👍🏼👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @marcoow @rwjblue