Skip to content

Commit

Permalink
tests/acceptance: Replace moduleForAcceptance() with `setupApplicat…
Browse files Browse the repository at this point in the history
…ionTest()`
  • Loading branch information
Turbo87 committed Nov 11, 2019
1 parent 323729b commit cc1bb51
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 113 deletions.
137 changes: 70 additions & 67 deletions tests/acceptance/bind-data-test-attributes-in-components-test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { test, skip } from 'qunit';
import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';
import { module, test, skip } from 'qunit';
import { setupApplicationTest } from 'ember-qunit';
import { visit } from '@ember/test-helpers';

import config from 'dummy/config/environment';
import { hasPositionalParams } from 'dummy/version-checks';
Expand All @@ -11,70 +12,72 @@ if (!config.stripTestSelectors) {
* because initializers are only applied in acceptance tests, but not in
* component integration tests.
*/
moduleForAcceptance('Acceptance | Initializer | ember-test-selectors', {
beforeEach() {
visit('/bind-test');
},
});

test('it binds data-test-* attributes on components', function(assert) {
assert.dom('.test1 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test1 div[data-test-first="foobar"]').exists('data-test-first has correct value');
});

test('it binds data-test-* attributes on components in block form', function(assert) {
assert.dom('.test2 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test2 div[data-test-first="foobar"]').exists('data-test-first has correct value');
});

test('it works with multiple data-test-* attributes on components', function(assert) {
assert.dom('.test3 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test3 div[data-test-first="foobar"]').exists('data-test-first has correct value');
assert.dom('.test3 div[data-test-second]').exists('data-test-second exists');
assert.dom('.test3 div[data-test-second="second"]').exists('data-test-second has correct value');
});

test('it leaves other data attributes untouched, when a data-test-* attribute is present as well on components', function(assert) {
assert.dom('.test4 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test4 div[data-test-first="foobar"]').exists('data-test-first has correct value');
assert.dom('.test4 div[data-non-test]').doesNotExist('data-non-test does not exists');
});

test('it leaves data-test attribute untouched on components', function(assert) {
assert.dom('.test5 div[data-test]').doesNotExist('data-test does not exists');
});

test('it leaves other data attributes untouched on components', function(assert) {
assert.dom('.test6 div[data-non-test]').doesNotExist('data-non-test does not exists');
});

test('it binds data-test-* attributes with boolean values on components', function(assert) {
assert.dom('.test7 div[data-test-with-boolean-value]').exists('data-test-with-boolean-value exists');
});

test('it binds data-test-* attributes without values on components', function(assert) {
assert.dom('.test8 div[data-test-without-value]').exists('data-test-without-value exists');
});

test('it binds data-test-* attributes without values on block components', function(assert) {
assert.dom('.test9 div[data-test-without-value]').exists('data-test-without-value exists');
});

(hasPositionalParams ? test : skip)('it leaves data-test attribute without value untouched on components', function(assert) {
assert.dom('.test10 div[data-test]').doesNotExist('data-test does not exists');
});

test('it transforms data-test params to hash pairs on components', function(assert) {
assert.dom('.test11 div[data-test-something]').exists('data-test-something exists');
});

test('it binds data-test attributes on {{link-to}} components', function(assert) {
assert.dom('.test-link-to-block a').hasAttribute('data-test-foo', 'bar');
assert.dom('.test-link-to-inline a').hasAttribute('data-test-foo', 'bar');
});

test('it handles the tagless components without assert when `supportsDataTestProperties` is set', function(assert) {
assert.dom('.test12 div[data-test-with-boolean-value]').doesNotExist('data-test-with-boolean-value does not exist');
assert.dom('.test13 div[data-test-without-value]').doesNotExist('data-test-without-value does not exist');
module('Acceptance | Initializer | ember-test-selectors', function(hooks) {
setupApplicationTest(hooks);

hooks.beforeEach(async function() {
await visit('/bind-test');
});

test('it binds data-test-* attributes on components', function(assert) {
assert.dom('.test1 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test1 div[data-test-first="foobar"]').exists('data-test-first has correct value');
});

test('it binds data-test-* attributes on components in block form', function(assert) {
assert.dom('.test2 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test2 div[data-test-first="foobar"]').exists('data-test-first has correct value');
});

test('it works with multiple data-test-* attributes on components', function(assert) {
assert.dom('.test3 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test3 div[data-test-first="foobar"]').exists('data-test-first has correct value');
assert.dom('.test3 div[data-test-second]').exists('data-test-second exists');
assert.dom('.test3 div[data-test-second="second"]').exists('data-test-second has correct value');
});

test('it leaves other data attributes untouched, when a data-test-* attribute is present as well on components', function(assert) {
assert.dom('.test4 div[data-test-first]').exists('data-test-first exists');
assert.dom('.test4 div[data-test-first="foobar"]').exists('data-test-first has correct value');
assert.dom('.test4 div[data-non-test]').doesNotExist('data-non-test does not exists');
});

test('it leaves data-test attribute untouched on components', function(assert) {
assert.dom('.test5 div[data-test]').doesNotExist('data-test does not exists');
});

test('it leaves other data attributes untouched on components', function(assert) {
assert.dom('.test6 div[data-non-test]').doesNotExist('data-non-test does not exists');
});

test('it binds data-test-* attributes with boolean values on components', function(assert) {
assert.dom('.test7 div[data-test-with-boolean-value]').exists('data-test-with-boolean-value exists');
});

test('it binds data-test-* attributes without values on components', function(assert) {
assert.dom('.test8 div[data-test-without-value]').exists('data-test-without-value exists');
});

test('it binds data-test-* attributes without values on block components', function(assert) {
assert.dom('.test9 div[data-test-without-value]').exists('data-test-without-value exists');
});

(hasPositionalParams ? test : skip)('it leaves data-test attribute without value untouched on components', function(assert) {
assert.dom('.test10 div[data-test]').doesNotExist('data-test does not exists');
});

test('it transforms data-test params to hash pairs on components', function(assert) {
assert.dom('.test11 div[data-test-something]').exists('data-test-something exists');
});

test('it binds data-test attributes on {{link-to}} components', function(assert) {
assert.dom('.test-link-to-block a').hasAttribute('data-test-foo', 'bar');
assert.dom('.test-link-to-inline a').hasAttribute('data-test-foo', 'bar');
});

test('it handles the tagless components without assert when `supportsDataTestProperties` is set', function(assert) {
assert.dom('.test12 div[data-test-with-boolean-value]').doesNotExist('data-test-with-boolean-value does not exist');
assert.dom('.test13 div[data-test-without-value]').doesNotExist('data-test-without-value does not exist');
});
});
}
5 changes: 0 additions & 5 deletions tests/helpers/destroy-app.js

This file was deleted.

21 changes: 0 additions & 21 deletions tests/helpers/module-for-acceptance.js

This file was deleted.

20 changes: 0 additions & 20 deletions tests/helpers/start-app.js

This file was deleted.

0 comments on commit cc1bb51

Please sign in to comment.