feat(test-esa) fix missing test scenarios #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.npmrc
Outdated
Comment on lines
2
to
3
| hoist=true | ||
| hoist-workspace-packages=true |
There was a problem hiding this comment.
This configuration would likely indicate problems with peer dependencies / dependencies of packages.
It used to be the trick in yarn to make monorepos work.
We should make the package resolutions stricter rather than relaxing it.
e.g.
# resolution-mode is here because of old pnpm problem in pre-8.0. This setting is now the default
resolution-mode=highest
auto-install-peers=false
resolve-peers-from-workspace-root=false
There was a problem hiding this comment.
Reverted this; but I'm still having the issue in #2864
Gaurav0
force-pushed
the
missing_test_scenarios
branch
from
26f526d to
ac80f8f
Compare
Gaurav0
force-pushed
the
missing_test_scenarios
branch
from
ac80f8f to
0db3b4f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing test scenarios for Ember 5.4, 5.12 LTS