feat(ember-simple-auth): implement internal EventTarget #2887
+78
−119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR removed Evented mixin that was used by the classes directly - which is a nice improvement and allows full conversion to native classes.
workspace:*
instead of a version.bind
when providing methods to event listeners, to decorating methods directlyUnfortunately extending from the native EventTarget such as
class MyClass extends EventTarget
fails under fastboot and presumably when typescript's involved too. The #2875 seemed to work fine unless typescript was involved.The issue isn't related to the
typescript-event-target
package that was introduced instead of Evented.Maybe our Fastboot & Typescript herald @mansona would know more?
Some error details after running
pnpm -F test-app test:one ember-4.0
onexp
branch which still contains changes from #2875 and introduces Typescript to a test-app project.master...exp