Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update to ember-engines 0.11.0 #2801

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Jul 5, 2024

Ember-engines made a breaking change between 0.10.0 -> 0.11.0.
This updates transitionToExternal calls to use router instead.

@BobrImperator BobrImperator force-pushed the update-ember-engines branch 2 times, most recently from 6e906c0 to 553803e Compare July 5, 2024 04:54
@BobrImperator BobrImperator requested a review from marcoow July 5, 2024 04:55
@BobrImperator BobrImperator force-pushed the update-ember-engines branch from 553803e to 3469ce0 Compare July 5, 2024 11:48
Copy link

github-actions bot commented Jul 5, 2024

Some tests with 'continue-on-error: true' have failed:

  • test-app test:one ember-beta

  • classic-test-app test:one ember-canary

  • test-esa test:one ember-beta

  • test-app test:one ember-canary

  • test-esa test:one ember-canary

    Created by continue-on-error-comment

@BobrImperator BobrImperator merged commit d744766 into master Jul 5, 2024
39 of 42 checks passed
@BobrImperator BobrImperator deleted the update-ember-engines branch July 5, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants