Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #2207

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fix CI #2207

merged 1 commit into from
Jun 3, 2020

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented May 29, 2020

We are running into an error on CI (ember-cli/babel-plugin-ember-modules-api-polyfill#64) currently for some of the ember-try scenarios (see e.g. #2198). This should fix that by upgrading ember-cli-babel to the latest version which includes the fix ember-cli/babel-plugin-ember-modules-api-polyfill#109.

@marcoow marcoow force-pushed the fix-build-error branch from 846796d to 9d0337f Compare May 29, 2020 07:06
@marcoow
Copy link
Member Author

marcoow commented May 29, 2020

We're now running into ember-cli/babel-plugin-ember-modules-api-polyfill#110

@rwjblue
Copy link
Contributor

rwjblue commented Jun 2, 2020

@marcoow - https://github.com/babel/ember-cli-babel/releases/tag/v7.20.5 has been published with more fixes. Would love if you could test and report any remaining failures.

@marcoow marcoow force-pushed the fix-build-error branch from 9d0337f to 97703be Compare June 2, 2020 15:56
@marcoow
Copy link
Member Author

marcoow commented Jun 2, 2020

Thanks a lot @rwjblue – this works now!

@marcoow marcoow marked this pull request as ready for review June 2, 2020 16:01
@marcoow marcoow requested a review from a team June 2, 2020 16:01
@marcoow marcoow merged commit dd769ab into master Jun 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-build-error branch June 3, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants