Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the release process #927

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Prepare the release process #927

merged 3 commits into from
Mar 15, 2024

Conversation

BlueCutOfficial
Copy link
Contributor

@BlueCutOfficial BlueCutOfficial commented Mar 1, 2024

We have merged #920 which converted ember-promise-modals to a v2 addon. Now, we must release the v5.0.0. To do so, we first need to adapt the release process to the new structure of the repository.

This PR:

  • Replaces release-it tool with release-plan, that fits the Ember v2 addons. An advantage of the tool is that it creates a release PR to be double-checked.
  • Delete the unnecessary script to run npm publish: it won't be used in the new release process and pnpm publish is already a command anyway.

@BlueCutOfficial BlueCutOfficial changed the title Prepare release Prepare the release process Mar 1, 2024
@BlueCutOfficial BlueCutOfficial mentioned this pull request Mar 1, 2024
2 tasks
@BlueCutOfficial BlueCutOfficial requested review from zeppelin, pichfl, nickschot and BobrImperator and removed request for zeppelin March 6, 2024 17:09
.github/workflows/release.yml Outdated Show resolved Hide resolved
packages/ember-promise-modals/package.json Outdated Show resolved Hide resolved
@pichfl
Copy link
Contributor

pichfl commented Mar 12, 2024

I want to pull in @mansona into this. The automated release process he introduced for https://github.com/pichfl/auto-reveal seemed quite useful.

This is only an idea though, so this shouldn't keep you from merging this one.

@BlueCutOfficial
Copy link
Contributor Author

Thanks @pichfl, I was a bit hesitant to implement release-plan in this PR. I guess at some point we should migrate to it but on the other hand, I felt like the PR would be doing too many things at the same time: all I wanted to do here is to adapt the existing to get the release work. I need to consider the review comments so I guess I still have a bit of time to decide if I want to do this in 1 or 2 steps :)

@mansona
Copy link
Member

mansona commented Mar 12, 2024

Sorry there was a bit of confusion with what would be needed to move to release-plan, essentially it's just run one step in your terminal npm init release-plan-setup@latest and it does all/most of the work for you.

Since you would need to change these files and then change them again I don't think it's worth merging this if we're ok with using release-plan. Here is a PR that converts us to using release-plan without needing to change anything else: #929

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean I may be a bit biased but it looks good to me 😂 the description of the PR is a bit outdated (maybe?) but otherwise LGTM 💪

@mansona
Copy link
Member

mansona commented Mar 12, 2024

the embroider issues seem to be an upstream floating dependency issue 😭 I think we can merge without worrying about them 👍

mansona and others added 3 commits March 15, 2024 16:54
I ran `npm init release-plan-setup@latest` and removed all release-it packages
@BlueCutOfficial BlueCutOfficial merged commit f3116da into main Mar 15, 2024
14 checks passed
@BlueCutOfficial BlueCutOfficial deleted the prepare-release branch March 15, 2024 16:00
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants