-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare the release process #927
Conversation
I want to pull in @mansona into this. The automated release process he introduced for https://github.com/pichfl/auto-reveal seemed quite useful. This is only an idea though, so this shouldn't keep you from merging this one. |
Thanks @pichfl, I was a bit hesitant to implement |
Sorry there was a bit of confusion with what would be needed to move to release-plan, essentially it's just run one step in your terminal Since you would need to change these files and then change them again I don't think it's worth merging this if we're ok with using release-plan. Here is a PR that converts us to using release-plan without needing to change anything else: #929 |
7244418
to
a976d54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I may be a bit biased but it looks good to me 😂 the description of the PR is a bit outdated (maybe?) but otherwise LGTM 💪
the embroider issues seem to be an upstream floating dependency issue 😭 I think we can merge without worrying about them 👍 |
I ran `npm init release-plan-setup@latest` and removed all release-it packages
e4cd9c9
to
b36f560
Compare
We have merged #920 which converted
ember-promise-modals
to a v2 addon. Now, we must release the v5.0.0. To do so, we first need to adapt the release process to the new structure of the repository.This PR:
release-it
tool withrelease-plan
, that fits the Ember v2 addons. An advantage of the tool is that it creates a release PR to be double-checked.npm publish
: it won't be used in the new release process andpnpm publish
is already a command anyway.