Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the addon to v2 #920

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Convert the addon to v2 #920

merged 2 commits into from
Mar 1, 2024

Conversation

BlueCutOfficial
Copy link
Contributor

This PR is the last step to convert the addon to v2:

  • It does the conversion
  • It also adds 4.12 LTS to the test scenarios
  • It adds some handy commands to the main package.json so the addon can be built and the test-app run locally without navigating in the packages.

@BlueCutOfficial BlueCutOfficial mentioned this pull request Feb 15, 2024
2 tasks
@BlueCutOfficial BlueCutOfficial force-pushed the step5-convert-to-v2-addon branch from b46ec50 to 7ad14a9 Compare February 16, 2024 10:27
@BlueCutOfficial BlueCutOfficial force-pushed the step5-convert-to-v2-addon branch from 7ad14a9 to d8fe054 Compare February 16, 2024 10:29
@BlueCutOfficial
Copy link
Contributor Author

I spotted a little issue with the CSS variables. The way it's done now, the :root can't be overridden easily, I think we expect it to be overridable. I'll look into it.

@BlueCutOfficial BlueCutOfficial merged commit 860cae3 into main Mar 1, 2024
14 checks passed
@BlueCutOfficial BlueCutOfficial deleted the step5-convert-to-v2-addon branch March 1, 2024 10:26
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants