Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use co-location in the addon package #919

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

BlueCutOfficial
Copy link
Contributor

@BlueCutOfficial BlueCutOfficial commented Feb 12, 2024

This PR is a step to convert the addon to v2. Now that we have a monorepo structure, we can work on meeting all the prerequisites before doing the actual conversion.

The present change is about using co-located templates.

Details:

The porting-addons-to-v2.md states the following:

Make sure your addon has co-located templates. By default, the build tools expect to find the component's .js and .hbs in the same folder. If your addon used to have an addon/templates/components folder, move to co-location. Note that a codemod has been released when co-location has become the recommended structure.

If we don't use co-location, the .js and the .hbs are compiled as two different components, the latter being template-only.

@BlueCutOfficial BlueCutOfficial mentioned this pull request Feb 12, 2024
2 tasks
@BlueCutOfficial BlueCutOfficial changed the title Use co-location Use co-location in the addon package Feb 12, 2024
@BlueCutOfficial BlueCutOfficial merged commit d2254d9 into main Feb 14, 2024
13 checks passed
@BlueCutOfficial BlueCutOfficial deleted the step4-colocated-templates branch February 14, 2024 17:00
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants