Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deprecated modal-from-string #913

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions DEPRECATIONS.md

This file was deleted.

15 changes: 0 additions & 15 deletions addon/services/modals.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { A } from '@ember/array';
import { deprecate } from '@ember/debug';
import { computed } from '@ember/object';
import { alias } from '@ember/object/computed';
import Service from '@ember/service';
Expand Down Expand Up @@ -41,20 +40,6 @@ export default Service.extend({
* @returns {Modal}
*/
open(componentClass, data, options) {
deprecate(
`Ember Promise Modals: For extended compatibility with Embroider and its tree-shaking ability, you need to import and pass in the component class of the modal component you want to display instead of "${componentClass}".`,
typeof componentClass !== 'string',
{
id: 'ember-promise-modals.modals-from-string',
until: '5.0.0',
for: 'ember-promise-modals',
since: {
enabled: '3.1.0',
},
url: 'https://github.com/mainmatter/ember-promise-modals/blob/main/DEPRECATIONS.md#ember-promise-modalsmodals-from-string',
},
);

let modal = new Modal(this, componentClass, data, options);

this._stack.pushObject(modal);
Expand Down
6 changes: 1 addition & 5 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ module.exports = async function () {
},
},
embroiderSafe(),
embroiderOptimized({
env: {
SKIP_EMBROIDER_DEPRECATION_TEST: true,
},
}),
embroiderOptimized(),
],
};
};
49 changes: 0 additions & 49 deletions tests/application/deprecations-test.js

This file was deleted.

1 change: 0 additions & 1 deletion tests/dummy/config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module.exports = function (environment) {

if (environment === 'test') {
// Testem prefers this...
ENV.SKIP_EMBROIDER_DEPRECATION_TEST = process.env.SKIP_EMBROIDER_DEPRECATION_TEST;
ENV.locationType = 'none';

// keep test console output quieter
Expand Down
Loading