Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ember < 3.28 and node < 16 #910

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

BlueCutOfficial
Copy link
Contributor

@BlueCutOfficial BlueCutOfficial commented Feb 2, 2024

This PR is a step of the conversion to v2 addon.

  • It removes the support for Ember < 3.28
  • It removes support for node < 16

Why?
Once the addon is converted to v2, the ember-try scenario start failing for Ember < 3.28. Also, the addon will require dependencies like [email protected] (to support static blocks) that require at least node 16.

Additionally, the PR:

  • resets the jquery-integration to false.
  • downgrade a node version to 16 in the CI to make sure 16 is still supported.

Copy link
Contributor

@pichfl pichfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! I don't think we've ever needed the jQuery integration for this addon anyway, so this is a welcome change.

@BlueCutOfficial BlueCutOfficial merged commit 969e8e8 into main Feb 7, 2024
13 checks passed
@BlueCutOfficial BlueCutOfficial deleted the step-2-drop-node-lt-16 branch February 7, 2024 08:28
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants