Remove the PostCSS process #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
force-pushed
the
step2-remove-post-css-process
branch
from
a1e9184 to
7ec4f5b
Compare
BlueCutOfficial
force-pushed
the
step2-remove-post-css-process
branch
from
7ec4f5b to
75b0882
Compare
BlueCutOfficial
force-pushed
the
step2-remove-post-css-process
branch
from
75b0882 to
b269d1a
Compare
nickschot
reviewed
Feb 2, 2024
nickschot
approved these changes
Feb 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a step of the conversion to v2 addon.
Why?
Build-time features no longer stand in Embroider world, because the v2 addons are static. To provide a processed CSS, we need to provide it statically, and this is not what we want: this process generated static fallbacks for CSS variables, but most browsers have been supporting CSS variables for several years. Also, the v1 addon offered the possibility to import the uncompiled style, so providing processed styles would kind of break this. The approach we chose is to remove this feature from the addon completely and document how to re-implement it on consumer app side.