Add support for listing redundant whitelist entries #649
Conversation
robinborst95
force-pushed
the
feature/unused-whitelist
branch
2 times, most recently
from
18ee8bf to
50a7430
Compare
| @@ -48,6 +48,19 @@ To prevent that from happening you can configure a `whitelist`, which accepts an | |||
| array of regular expressions that will be checked when looking for unused | |||
| translations. | |||
|
|
|||
| ### `errorOnUnusedWhitelistEntries` | |||
There was a problem hiding this comment.
I think it's nice to make the exit code dependent on unused whitelist entries as well. However, I chose to leave this as a config option, so that current users aren't affected by this change. Alternative is just not having this config option and still error, but this might block applications after upgrading. Also, if this feature contains a bug that I overlooked, it's easy to turn it off.
There was a problem hiding this comment.
I think we will keep it opt in for now, and see how it goes and that it is working well, then i think for the next Major version i think i will have this on by default.
|
|
||
| if (isKeyMissing && isKeyAllowed) { | ||
| if (!isKeyMissing) continue; |
There was a problem hiding this comment.
Little performance improvement here; if the key wasn't missing, it would still be looked up in the whitelist, which is useless.
| if (!isKeyMissing) continue; | ||
|
|
||
| const whitelistKey = whitelist.find(regex => regex.test(keyTrimmed)); | ||
| const isKeyWhitelisted = whitelistKey != null; |
There was a problem hiding this comment.
I find it easier to follow when called isKeyWhitelisted as opposed to isKeyAllowed
Mikek2252
force-pushed
the
feature/unused-whitelist
branch
from
f74de25 to
c150f43
Compare
Implements #645.