redirect if login page session expired - fixes #1107 #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I close this issue? |
|
Oops sorry. Already done. May be it's time to publish 1.2.11 ? ;-) |
|
I am running the latest master 1.2.13 and this problem still exists year later. Anything I can do to help resolve or test this? |
|
Hi @dajones70 You are still seeing the token error on the login page? Does the login page ever expire as expected with this PR, or does it just sit on that screen indefinitely and then throw a token error? |
|
I am not sure if this is related but i am running the current latest version and the session timeout setting has no effect. I am having to log in again almost every time I look at the page and it's making me log in twice before it will let me in. I am not seeing a token message though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1107
If the session on the login page expires (->invalid token) don't show token error but redirect to login page and ask user to login again