fix: [#2032] local status cmd reports status correctly
#2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a service-based network, a node was determined to be running by searching for a process whose path matched the path where the service binary is installed. This works because those are unique paths. However, it did not work for a local network, because each process uses a binary at the same path. For a status refresh, we now distinguish between a service-based network and a local network. For the local network, we determine if a node is running simply by connecting to its RPC service.
jacderida
force-pushed
the
fix-node_man-local_status
branch
from
1119a1d to
a9c6d88
Compare
joshuef
approved these changes
Sep 1, 2024
|
This still does not work for me: https://forum.autonomi.community/t/update-15-august-2024/40225/34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a service-based network, a node was determined to be running by searching for a process whose path matched the path where the service binary is installed. This works because those are unique paths. However, it did not work for a local network, because each process uses a binary at the same path.
For a status refresh, we now distinguish between a service-based network and a local network. For the local network, we determine if a node is running simply by connecting to its RPC service.
Related Issue
Fixes #2035
Type of Change
Please mark the types of changes made in this pull request.