Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet code/logic changes #2032

Closed
6 tasks
mickvandijke opened this issue Aug 8, 2024 · 0 comments
Closed
6 tasks

wallet code/logic changes #2032

mickvandijke opened this issue Aug 8, 2024 · 0 comments
Assignees
@mickvandijke
Labels
Breaking Change Refactor

Comments

@mickvandijke
Copy link
Contributor

mickvandijke commented Aug 8, 2024 •
edited
Loading

The current wallet code and logic should be cleaned/simplified and inspired by Ethereum and Bitcoin. It should be secure and simple.

Notes:

  • Stop writing unencrypted sensitive data to disk (mnemonic, secret keys).
  • Prepare the code for multi-wallet support.
  • Prepare the code for hardware wallet support (Ledger, Trezor, etc..).

Tasks:

  • Remove deposit API.
  • Merge payments, confirmed_spends & cash_notes folders into the wallet file.
  • Graciously handle race conditions regarding wallet access to prevent simultaneous use of the same CashNote.
  • Handle receiving the same CashNoteRedemption multiple times.
  • Handle the scenario where a Spend fails to upload.
  • Merge watch-only wallet and hotwallet into a single wallet struct.
@mickvandijke mickvandijke self-assigned this Aug 8, 2024
@mickvandijke mickvandijke changed the title refactor the wallet code in sn_client wallet code/logic changes Aug 12, 2024
jacderida added a commit to jacderida/autonomi that referenced this issue Aug 31, 2024
@jacderida
fix: [maidsafe#2032] local status cmd reports status correctly
1119a1d 
In a service-based network, a node was determined to be running by searching for a process whose
path matched the path where the service binary is installed. This works because those are unique
paths. However, it did not work for a local network, because each process uses a binary at the same
path.

For a status refresh, we now distinguish between a service-based network and a local network. For
the local network, we determine if a node is running simply by connecting to its RPC service.
jacderida added a commit to jacderida/autonomi that referenced this issue Aug 31, 2024
@jacderida
fix: [maidsafe#2032] local status cmd reports status correctly
a9c6d88 
In a service-based network, a node was determined to be running by searching for a process whose
path matched the path where the service binary is installed. This works because those are unique
paths. However, it did not work for a local network, because each process uses a binary at the same
path.

For a status refresh, we now distinguish between a service-based network and a local network. For
the local network, we determine if a node is running simply by connecting to its RPC service.
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@joshuef
Merge pull request #2079 from jacderida/fix-node_man-local_status
e5e554a 
fix: [#2032] `local status` cmd reports status correctly
@mickvandijke mickvandijke closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mickvandijke mickvandijke

Labels
Breaking Change Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mickvandijke