fix: evmlib error escaped retry & skip pay free chunks #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickvandijke
commented
Feb 4, 2025
•
mickvandijke
commented
- Retry transaction broadcasting.
- Skip paying free chunks (Bit out of place I know, but it is a very small change).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let lock_guard = wallet.lock().await; | ||
| debug!("Locked wallet"); | ||
|
|
||
| // TODO: the error might contain some succeeded quote payments as well. These should be returned on err, so that they can be skipped when retrying. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| debug!("Locked wallet"); | ||
|
|
||
| // TODO: the error might contain some succeeded quote payments as well. These should be returned on err, so that they can be skipped when retrying. | ||
| // TODO: retry when it fails? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
mickvandijke
changed the title
jacderida
approved these changes
Feb 4, 2025
mickvandijke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.