chore: versioning for ant binary
#2534
Open
+78
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the `ant` binary in alignment with how versioning is handled for the other binaries. As with the other binaries, to save a lot of hassle, the version arguments are implemented 'manually' rather than using the direct mechanism from `clap`. Therefore, to get the expected behaviour, the main subcommand has to be made optional. From the user's point of view nothing changes. I took the opportunity to also sort the arguments alphabetically. This is how they are organised in the node manager, and I find it makes for easier reference.
jacderida
force-pushed
the
chore-versioning_for_new_branding
branch
from
c89d9bc to
68118cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the
antbinary in alignment with how versioning is handled for the other binaries.As with the other binaries, to save a lot of hassle, the version arguments are implemented 'manually' rather than using the direct mechanism from
clap. Therefore, to get the expected behaviour, the main subcommand has to be made optional. From the user's point of view nothing changes.I took the opportunity to also sort the arguments alphabetically. This is how they are organised in the node manager, and I find it makes for easier reference.