chore: avoid access Distance private field of U256 #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
bypass_Distance_private_field
branch
from
e938394 to
8e4335e
Compare
jacderida
approved these changes
Dec 11, 2024
| @@ -20,6 +20,7 @@ upnp = ["libp2p/upnp"] | |||
|
|
|||
| [dependencies] | |||
| aes-gcm-siv = "0.11.1" | |||
| alloy = { version = "0.5.3", default-features = false, features = ["std", "reqwest-rustls-tls", "provider-anvil-node", "sol-types", "json", "signers", "contract", "signer-local", "network"] } | |||
There was a problem hiding this comment.
Was this only added for the U256 type? Cause the type is in ant_evm::common::U256 already 🤔
EDIT: Hmm actually, it is in evmlib::common::U256, but ant_evm doesn't re-export it yet. I think it would be a cleaner solution to re-export it through ant_evm than adding Alloy as dependency.
There was a problem hiding this comment.
^ I'll do that in my merge commit for PR # 2519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
avoid access Distance private field of U256
also rolls back the libp2p dependency to the previous 0.54.1