Feat upgradable smart contracts and updated quotation flow #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickvandijke
commented
Dec 9, 2024
| @@ -77,6 +77,21 @@ impl ProofOfPayment { | |||
| .any(|(_, quote)| quote.has_expired()) | |||
| } | |||
|
|
|||
| /// Returns all quotes by given peer id | |||
| pub fn quotes_by_peer(&self, peer_id: &PeerId) -> Vec<&PaymentQuote> { | |||
There was a problem hiding this comment.
Should this also check that the quote is valid for the same peer id?
There was a problem hiding this comment.
I think this is caller responsibility? The name doesn't suggest a check is there
grumbach
reviewed
Dec 10, 2024
| let put_cfg = PutRecordCfg { | ||
| put_quorum: Quorum::All, | ||
| retry_strategy: None, | ||
| use_put_record_to: Some(vec![payee]), | ||
| use_put_record_to: Some(payees), // CODE REVIEW: should we put to all or just one here? |
There was a problem hiding this comment.
All sounds good. Maybe in the future, to strain the network less we could put to 1 by 1 until the data is stored
There was a problem hiding this comment.
This can come as an optimization
grumbach
reviewed
Dec 10, 2024
| @@ -146,19 +150,21 @@ impl Client { | |||
| let put_cfg = PutRecordCfg { | |||
| put_quorum: Quorum::One, | |||
| retry_strategy: Some(RetryStrategy::Balanced), | |||
| use_put_record_to: Some(vec![storing_node]), | |||
| use_put_record_to: Some(storing_nodes), // CODE REVIEW: do we put to all payees or just one? | |||
There was a problem hiding this comment.
Same here, this would be a good optimization down the line but maybe in the put_record code layer?
grumbach
reviewed
Dec 10, 2024
Comment on lines
+47
to
+50
| // CODE REVIEW: should we fail on a single invalid payment? | ||
| if !payment_verification.is_valid { | ||
| return Err(error::Error::PaymentInvalid); | ||
| } |
There was a problem hiding this comment.
For now yeah, I guess this will be a question again when we batch this
grumbach
merged commit 0279010
into
maidsafe:feat-upgradable-smart-contracts-and-updated-quotation-flow
11 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autonomicompiles!Still some tests to fix most likely though and need to have the final smart contract implementation to fix local deployment on Anvil.
Look for
@anselmeand// CODE REVIEWfor parts where I was a bit unsure!