feat: python safenode module #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Python bindings using PyO3 to allow direct programmatic control of safenode instances. This enables Python applications to create and manage Safe Network nodes without using the CLI or RPC interface. Key changes: - Add PyO3 integration and module structure - Implement SafeNode Python class with core node functionality - Add proper error handling and type conversions - Include example code and documentation - Add maturin build configuration
Adds comprehensive storage operations to the Python bindings, allowing direct
manipulation of node storage from Python applications.
Key changes:
- Add store_record() method for storing chunks with proper type handling
- Add get_record() method for retrieving stored data
- Add delete_record() method for removing stored data
- Add get_stored_records_size() for storage statistics
- Fix RecordKey and NetworkAddress type conversions
- Update example.py with storage operation demonstrations
- Update README with storage operation documentation
The storage operations now properly handle:
- Hex key conversions
- Record type validation
- Proper Kad record creation
- Network address and record key conversions
- Error handling and type safety
Example usage:
```python
node.store_record("1234abcd", b"Hello Network!", "chunk")
data = node.get_record("1234abcd")
size = node.get_stored_records_size()
```
This reverts commit 66b575d.
…gs"" This reverts commit 359029d.
Merge branch 'temp' into python
Also added flags to prevent publish of python workflows for now.
jacderida
reviewed
Nov 10, 2024
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - 'XXX*' | ||
| - '*' |
There was a problem hiding this comment.
I think this would trigger the workflow when any tag is pushed. I don't think we want this.
For now, I would just remove the whole trigger from the workflow. We can come back to this when we incorporate the bindings into the release process.
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - 'v*' | ||
| - '*' |
There was a problem hiding this comment.
I think this would trigger the workflow when any tag is pushed. I don't think we want this.
For now, I would just remove the whole trigger from the workflow. We can come back to this when we incorporate the bindings into the release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request. Highlight the purpose of the changes and the problem they address.
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.
Checklist
Please ensure all of the following tasks have been completed: