Attempt to fix CPU issues, need more work to fully remove RBS #2367
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let _ = metrics_recorder | ||
| .current_reward_wallet_balance | ||
| .set(new_value); | ||
| .inc_by(storecost.as_atto().try_into().unwrap_or(i64::MAX)); // TODO maybe metrics should be in u256 too? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| // info!("Verifying new balance on paying wallet is {new_balance} ..."); | ||
| // let paying_wallet = wallet_client.into_wallet(); | ||
| // assert_eq!(paying_wallet.balance(), new_balance); | ||
| // // assert_eq!(paying_wallet.balance(), new_balance);// TODO adapt to evm |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
| // ); | ||
| // println!("Verifying new balance on paying wallet is now {new_balance} ..."); | ||
| // let paying_wallet = wallet_client.into_wallet(); | ||
| // assert_eq!(paying_wallet.balance(), new_balance); | ||
| // // TODO adapt to evm |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
| // let _ = wallet_client | ||
| // .mut_wallet() | ||
| // .local_send_storage_payment(&no_data_payments)?; | ||
| // // TODO adapt to evm |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
|
Closing as a result of merging #2369. |
Shall get replaced by PR #2369