Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(autonomi): allow the uploader to work with the new apis" #2334

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

grumbach
Copy link
Member

Reverts #2258

  1. Uploader creates heaps of new cryptic errors like Internal Error Too many sequential payment errors reported during upload that come from the old sn_cli which we deleted in part for this reason.

  2. Secondly, sn_networking fns already implements the features the uploader adds:

  • retries
  • verification
    Which means we end up with lots of duplicate logic.
  1. Uploader adds 3000 lines of hardly maintainable code from sn_cli to autonomi lib, slowing future progress

For all the reasons above and to keep simplicity and autonomi lib sane, I suggest we revert this.

@grumbach grumbach enabled auto-merge October 28, 2024 08:28
@grumbach grumbach added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 31721be Oct 28, 2024
28 checks passed
@grumbach grumbach deleted the revert-2258-optimize_uploads branch October 28, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants