Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): make the nightly tests work with evm #2310

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(ci): make the nightly tests work with evm #2310

merged 1 commit into from
Oct 25, 2024

Conversation

RolandSherwin
Copy link
Member

  • also increases "large file" download time from 2 mins to 3 mins inisde merge.yml

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 24, 2024
View reviewed changes
.github/workflows/nightly.yml
# only set the target dir for windows to bypass the linker issue.
# happens if we build the node manager via testnet action
CARGO_TARGET_DIR: ${{ matrix.os == 'windows-latest' && './test-target' || '.' }}
timeout-minutes: 15

- name: Create and fund a wallet to pay for files storage

# FIXME: do this in a generic way for localtestnets

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
.github/workflows/nightly.yml
timeout-minutes: 1
# get the counts, then the specific line, and then the digit count only
# then check we have an expected level of restarts
# TODO: make this use an env var, or relate to testnet size

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@RolandSherwin RolandSherwin force-pushed the fix_nightly branch 2 times, most recently from aadab94 to d8fcb3b Compare October 24, 2024 11:26
maqi
maqi requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@maqi maqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • comment out tests (spend, token) can actually be removed ?
  • can the nightly tests got executed somehow? or it can only be executed (to confirm they work as expected) AFTER the merge and wait for a day ?

@RolandSherwin RolandSherwin force-pushed the fix_nightly branch 2 times, most recently from bb176b2 to 5563572 Compare October 24, 2024 11:37
@RolandSherwin RolandSherwin added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@RolandSherwin RolandSherwin added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@maqi maqi added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@maqi maqi added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@maqi maqi added this pull request to the merge queue Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
@maqi
Merge pull request #2310 from RolandSherwin/fix_nightly
72f53e1 
fix(ci): make the nightly tests work with evm
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@maqi maqi added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@maqi maqi added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024
@RolandSherwin RolandSherwin added this pull request to the merge queue Oct 25, 2024
Merged via the queue into maidsafe:main with commit 5f7ada9 Oct 25, 2024
27 of 28 checks passed
@RolandSherwin RolandSherwin deleted the fix_nightly branch October 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazzi mazzi mazzi left review comments

@maqi maqi maqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RolandSherwin @mazzi @maqi