chore(launchpad): refactor status screen #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn update_node_items(&mut self) -> Result<()> { | ||
| // Iterate over existing node services and update their corresponding NodeItem | ||
| if let Some(ref mut items) = self.items { | ||
| for (node_item, item) in self.node_services.iter().zip(&mut items.items) { |
There was a problem hiding this comment.
Would this cause an issue if node_services.len() > items.len()? The items field is updated only during // If items is None, create a new list (fallback) part of the code. This would mean that if we were to add a new node, just the node_services would be updated and not items. Then the zip() would ignore these new nodes.
There was a problem hiding this comment.
The solution is to keep node_services and items in sync.
There was a problem hiding this comment.
We will not delete nodes just now. That hopefully will come in the next PR when we manage nodes individually.
Thanks for your feedback @RolandSherwin !
RolandSherwin
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To unify patterns and to be prepared for the next feature, we use now
NodeItemand aStatefulTablefor the status screen as we use on the drive selection and connection popups.With this architecture is easier to understand how to update the real time node status and changing rendering modes per node. We update stats and spinners on
Tick.Next feature: Call To Actions on individual nodes.