feat(register)!: network only store ops list #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
refactor_register
branch
from
04916f1 to
0275fac
Compare
b-zee
reviewed
Sep 25, 2024
|
|
||
| /// Register data type as a CRDT with Access Control | ||
| #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq, Hash, PartialOrd)] | ||
| pub(crate) struct RegisterCrdt { | ||
| pub struct RegisterCrdt { |
There was a problem hiding this comment.
Is there a specific motivation for making these items pub?
There was a problem hiding this comment.
@b-zee I think that's needed so that the API can expose the MerkleReg. That's necessary for access to the history, and without it usefulness of Registers becomes very limited. Not useful really!
You can look at/use the awe inspect-register command and implementation for some of the things that are needed.
There was a problem hiding this comment.
Yes, we do want to expose the underlying register. But that would be the MerkleReg type. Our RegisterCrdt is not something we want to promise anything about for the future.
maqi
force-pushed
the
refactor_register
branch
from
0275fac to
09c72e4
Compare
b-zee
approved these changes
Oct 1, 2024
maqi
force-pushed
the
refactor_register
branch
from
09c72e4 to
475bd0d
Compare
BREAKING CHANGE! crdt MerkleReg only stored in client locally node side only store ops list (signed by owner)
maqi
force-pushed
the
refactor_register
branch
from
475bd0d to
c214a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE!
crdt MerkleReg only stored in client locally
node side only store ops list (signed by owner)