Merge pull request #2095 from b-zee/refactor-clippy

refactor(cli/faucet): clippy suggestions

sn_cli/src/files/upload.rs

@@ -44,30 +44,27 @@ impl UploadedFile {
                 self.filename
             );
         }
-        let serialized = rmp_serde::to_vec(&(&self.filename, &self.data_map)).map_err(|err| {
-            error!("Failed to serialize UploadedFile");
-            err
-        })?;
+        let serialized =
+            rmp_serde::to_vec(&(&self.filename, &self.data_map)).inspect_err(|_err| {
+                error!("Failed to serialize UploadedFile");
+            })?;
 
-        std::fs::write(&uploaded_file_path, serialized).map_err(|err| {
+        std::fs::write(&uploaded_file_path, serialized).inspect_err(|_err| {
             error!(
                 "Could not write UploadedFile of {:?} to {uploaded_file_path:?}",
                 self.filename
             );
-            err
         })?;
 
         Ok(())
     }
 
     pub fn read(path: &Path) -> Result<Self> {
-        let bytes = std::fs::read(path).map_err(|err| {
+        let bytes = std::fs::read(path).inspect_err(|_err| {
             error!("Error while reading the UploadedFile from {path:?}");
-            err
         })?;
-        let metadata = rmp_serde::from_slice(&bytes).map_err(|err| {
+        let metadata = rmp_serde::from_slice(&bytes).inspect_err(|_err| {
             error!("Error while deserializing UploadedFile for {path:?}");
-            err
         })?;
         Ok(metadata)
     }

sn_faucet/src/faucet_server.rs

@@ -65,11 +65,10 @@ use tokio::{fs, io::AsyncWriteExt};
 pub async fn run_faucet_server(client: &Client) -> Result<()> {
     let root_dir = get_faucet_data_dir();
     let wallet = load_account_wallet_or_create_with_mnemonic(&root_dir, None)?;
-    claim_genesis(client, wallet).await.map_err(|err| {
+    claim_genesis(client, wallet).await.inspect_err(|_err| {
         println!("Faucet Server couldn't start as we failed to claim Genesis");
         eprintln!("Faucet Server couldn't start as we failed to claim Genesis");
         error!("Faucet Server couldn't start as we failed to claim Genesis");
-        err
     })?;
 
     #[cfg(feature = "initial-data")]