Skip to content

Commit

Permalink
Bugfix for Hover which is visible above other application windows. ec…
Browse files Browse the repository at this point in the history
…lipse-platform#2534

This patch is fixing the problem, where the HoverManagers listeners are
deregistered but the hover is still visibile on top. This happens when
the hover was sticky eclipse was minimized and put back on foreground
after it. THe shell visibility was set to false explicitly.

Originally the isVisible() was returning false and it won't be set to
visible explicitly.

Version bump(s) for 4.35 stream
  • Loading branch information
mehmet-karaman authored and mai-tran-03 committed Dec 10, 2024
1 parent 81053d1 commit da7d6ae
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface.text
Bundle-Version: 3.26.0.qualifier
Bundle-Version: 3.26.100.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,6 @@ else if (!resizable)
@Override
public void setVisible(boolean visible) {
Shell shell= getShell();
if (shell.isVisible() == visible)
return;

if (!visible) {
super.setVisible(false);
Expand All @@ -342,6 +340,8 @@ public void setVisible(boolean visible) {
return;
}

if (shell.isVisible() == visible)
return;
/*
* The Browser widget flickers when made visible while it is not completely loaded.
* The fix is to delay the call to setVisible until either loading is completed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ public boolean isResizable() {

@Override
public void setVisible(boolean visible) {
if (fShell.isVisible() == visible)
if (visible && fShell.isVisible() == visible)
return;

fShell.setVisible(visible);
Expand Down

0 comments on commit da7d6ae

Please sign in to comment.