Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #124

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Bug fixes #124

merged 3 commits into from
Nov 29, 2024

Conversation

doluk
Copy link
Contributor

@doluk doluk commented Nov 23, 2024

Fixes:

  • The broken meta or title tags caused by utf8 emojis in the channel or server name. Those were replaced with images like emojis in messages, but due to the " in the new text the tags were not recognized correctly
  • The issue when embedding the attachment data directly into the transcript that the code would break trying to figure out the file icon for the attachment as the proxy_url wouldn't contain any .fileextension anymore. It now falls back to the filename in such cases. Furthermore the IndexError should be avoided by rsplit in combination with indexing with -1 instead of 1.

Improves:

  • Refactoring a part of the the message parsing logic of references to make it more readable and easier maintainable.

@mahtoid mahtoid self-requested a review November 29, 2024 22:14
@mahtoid mahtoid merged commit 624d15f into mahtoid:master Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants