Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation URL for PyPI and use README to power long_description #122

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Add Documentation URL for PyPI and use README to power long_description #122

merged 2 commits into from
Nov 14, 2019

Conversation

andriyor
Copy link
Contributor

Warehouse now uses the project_urls provided to display links in the sidebar as well as including them in API responses. For example, see Django's setup.cfg and PyPI listing.

PyPI also already support rendering project descriptions from Markdown https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi/

use readme as long_description
@mahmoud
Copy link
Owner

mahmoud commented Nov 14, 2019

Sounds good to me! As you can see, the CI job that checks packaging coherence is failing right now. I recommend bumping the deps in the tox.ini under that name (the versions in there are around 2 years old!), and running the tox locally, if you can. There may need to be some markdown fixup that happens because GitHub is more lenient than PyPI.

@mahmoud mahmoud changed the title Add Documentation URL for PyPi Add Documentation URL for PyPI and use README to power long_description Nov 14, 2019
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          19       19           
  Lines        2511     2511           
  Branches      362      362           
=======================================
  Hits         2426     2426           
  Misses         45       45           
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e0555...8ed9a88. Read the comment docs.

@andriyor
Copy link
Contributor Author

Seems like readme checker need only for reStructuredText
https://packaging.python.org/guides/making-a-pypi-friendly-readme/#validating-restructuredtext-markup

tox.ini Show resolved Hide resolved
@mahmoud
Copy link
Owner

mahmoud commented Nov 14, 2019

Seems like readme checker need only for reStructuredText
https://packaging.python.org/guides/making-a-pypi-friendly-readme/#validating-restructuredtext-markup

Interesting, so it doesn't give any valuable feedback on the current readme? Might be nice to have some checking because it's pretty annoying to have to rev versions just to fix the docs, which is usually why I keep them really simple on PyPI :)

@mahmoud
Copy link
Owner

mahmoud commented Nov 14, 2019

Well I think that's all my concerns resolved. This has been very helpful, thank you so much!

@mahmoud mahmoud merged commit 15d3eca into mahmoud:master Nov 14, 2019
@mahmoud
Copy link
Owner

mahmoud commented Nov 14, 2019

I'll follow up and fix up the URLs in the readme to be compatible (absolute, pointing at github raw) before the next release (unless you want to take a stab at it!) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants