Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc features #9

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Misc features #9

merged 8 commits into from
Dec 14, 2023

Conversation

mahendrapaipuri
Copy link
Owner

@mahendrapaipuri mahendrapaipuri commented Dec 13, 2023

  • If /run/slurmjobstat file is not found, look for env vars in /proc file system. This needs CAP_SYS_PTRACE cap on binary
  • IPMI command can be executed as root if needed. Need caps on binary
  • Name after GPU ordinal numbers in /run/gpustat rather than UUID

* If prolog scripts are not executed, we attempt to get env vars from procs

* Remove work dir from job id calculation as the env var is not available inside process

* This needs CAP_SYS_PTRACE capability on binary to work

Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* Support only ordinal number for the moment

* Current implementation might not work for MIG devices

* We need to have a fallback to check for file name with UUID

Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
@mahendrapaipuri mahendrapaipuri added the enhancement New feature or request label Dec 13, 2023
* Now ipmi can be run as root directly in the exporter

* Users can still use wrapper approach if they want

Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
@mahendrapaipuri mahendrapaipuri changed the title Get env vars from /proc Misc features Dec 14, 2023
@mahendrapaipuri mahendrapaipuri merged commit 759cbad into main Dec 14, 2023
4 of 5 checks passed
@mahendrapaipuri mahendrapaipuri deleted the env_vars_from_procfs branch December 14, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant